add SQL parameter values in RequestLogLine so they can be logged/emitted#19067
Merged
clintropolis merged 2 commits intoapache:masterfrom Mar 19, 2026
Merged
Conversation
clintropolis
force-pushed
the
log-dynamic-parameter-values
branch
from
cb9fec5 to
2b3efbc
Compare
clintropolis
force-pushed
the
log-dynamic-parameter-values
branch
from
2b3efbc to
c177b64
Compare
abhishekrb19
approved these changes
Mar 3, 2026
|
|
||
| public static RequestLogLine forSql( | ||
| String sql, | ||
| List<ClientSqlParameter> parameters, |
Contributor
There was a problem hiding this comment.
nit: add @Nullable since we explicitly pass null in the above call
| } | ||
|
|
||
| /** | ||
| * Convert parameters list to serde friendly {@link SqlParameter} |
Contributor
There was a problem hiding this comment.
Suggested change
| * Convert parameters list to serde friendly {@link SqlParameter} | |
| * Convert parameters list to serde friendly {@link ClientSqlParameter} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently SQL dynamic parameter values are not logged or emitted. This PR adds them to
RequestLogLineso they can be logged and emitted with all the other stuff. This is useful for reconstructing the query when troubleshooting errors, since otherwise we only have the SQL with a bunch of?.